Ip address #37

Merged
merged 4 commits into from Dec 5, 2017

Conversation

Projects
None yet
3 participants
@bengitscode
Contributor

bengitscode commented Dec 1, 2017

Adds the bash script from #36 into README

bengitscode added some commits Dec 1, 2017

Adds bash script from #36 to be used in README
- Adds bash script from #36 to be used in README installation steps.
- Checks IP address.
Change IP address check to use bash script
- Changes check for local IP address to use the bash script Caleb wrote.
- Address and Close #36
@MicFin

Please add comments to that script that explain the code.

@@ -0,0 +1 @@
ifconfig | grep -Eo 'inet (addr:)?10\.([0-9]*\.){2}[0-9]*' | grep -Eo '10\.([0-9]*\.){2}[0-9]*' | grep -v '127.0.0.1'

This comment has been minimized.

@MicFin

MicFin Dec 4, 2017

Contributor

Code like this should probably have comments explaining it. More comments, the better, for future us.

bengitscode added some commits Dec 5, 2017

Make getIpAddress.sh file execuatable
- chmod +x scripts/getIpAddress.sh
Add annotationes to getIpAddress.sh script
- Add a shebang to head.
- Adds annotations from discussion in #36
- Close #36

@caleb-pearce caleb-pearce merged commit 44d1c8b into master Dec 5, 2017

@caleb-pearce caleb-pearce deleted the ip-address branch Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment