Submitting Homework 2 #8

Merged
merged 5 commits into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@ackalil

ackalil commented Dec 3, 2018

No description provided.

@vodnik

vodnik approved these changes Dec 12, 2018

const fizzBuzzArray = [];

for (let i = 1; i < 101; i++) {
if ((i % 15 === 0)) { // simpler than `(i % 3 === 0) && (i % 5 === 0)`; must come first AFAICT

This comment has been minimized.

@vodnik

vodnik Dec 12, 2018

Owner

Yes! Has to come first or the values get captured by fizz or buzz.

};

function logArrayElements(element, index, array) {
return (i + ': ' + element);

This comment has been minimized.

@vodnik

vodnik Dec 12, 2018

Owner

Nice use of multiple parameters, as well as a nested function.

breed: 'mixed',
noise: 'bark',
makeANoise: function() {
console.log('Woof!');

This comment has been minimized.

@vodnik

vodnik Dec 12, 2018

Owner

How could you rewrite this to use the value of the noise property you defined above?

*/

function fahrenheitToCelsius(fahrenheit) {
celsius = ((fahrenheit - 32) / 1.8);

This comment has been minimized.

@vodnik

vodnik Dec 12, 2018

Owner

I like the clarity introduced by your use of nested parens.

// to the preview.png image.


// ACK NOTE: There is no `index.html` in this project directory but there is a `blog.html` so I assume that's what I should be opening. The directions should be updated.

This comment has been minimized.

@vodnik

vodnik Dec 12, 2018

Owner

Sorry about that! Thanks for the note.

@vodnik vodnik merged commit b014791 into vodnik:master Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment