submitting Homework 2 #6

Merged
merged 2 commits into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@luisynayan

luisynayan commented Dec 3, 2018

No description provided.

@vodnik

vodnik approved these changes Dec 12, 2018

// Add an `if/else` statement that logs the string `"fizz"` if the value being iterated over is divisible by `3`; otherwise, log out the value.

// for (let i = 1; i <= 100; i++){
// if (i%3 === 0){

This comment has been minimized.

@vodnik

vodnik Dec 12, 2018

Owner

I recommend getting in the habit of including a space around each operator, for readability.

// ##### Step 2:
// Add an `if/else` statement that logs the string `"fizz"` if the value being iterated over is divisible by `3`; otherwise, log out the value.

// for (let i = 1; i <= 100; i++){

This comment has been minimized.

@vodnik

vodnik Dec 12, 2018

Owner

I like that you kept each iteration as a comment and expanded on it for each step.

}
}

myArray.forEach(function(element, myIndex){

This comment has been minimized.

@vodnik

vodnik Dec 12, 2018

Owner

Nice work implementing a two-parameter forEach statement!

breed: 'Poodle',
noise: 'bark',
makeNoise: function(){
console.log(this.petName + ' says: ' + this.noise);

This comment has been minimized.

@vodnik

vodnik Dec 12, 2018

Owner

Nice job using this to make a flexible object.



function toCelsius(tempInFarenheit){
tempInFarenheit = document.getElementById('temperature').value;

This comment has been minimized.

@vodnik

vodnik Dec 12, 2018

Owner

Don't forget to declare your variables! (const would work fine here)

let myBonusLI4 = document.createElement('li');
let myBonusLI5 = document.createElement('li');
let myBonusLI6 = document.createElement('li');
let myBonusA1 = document.createElement('a');

This comment has been minimized.

@vodnik

vodnik Dec 12, 2018

Owner

Nice work going the extra mile to include nested a elements!

flickrObj and store the the links to each item in the 'links' array.
*/
let links = [];
flickrObj.items.forEach(element => {

This comment has been minimized.

@vodnik

vodnik Dec 12, 2018

Owner

I'm glad to see you're expanding your repertoire by using arrow functions.

@vodnik vodnik merged commit cb5e71a into vodnik:master Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment