Submitting Homework 5 & 6 #16

Merged
merged 2 commits into from Jan 17, 2019

Conversation

Projects
None yet
2 participants
@ackalil

ackalil commented Jan 8, 2019

No description provided.

@vodnik

vodnik approved these changes Jan 17, 2019

Great job, Anna! You clearly have a solid handle on making API requests and performing DOM manipulation using JavaScript.

);

// Step 1: Create the getWeather function
function getWeather() { // why doesn't this take weatherUrl and lat and lon as parameters?

This comment has been minimized.

@vodnik

vodnik Jan 17, 2019

Owner

I agree that would be a useful enhancement!

}); // closes getCurrentPosition
} /* closes navigator.geolocation */ else {
// let's append to the images class
$('.images').append('Please enable geolocation in your browser.'); // this error doesn't appear if you block the prompt upon loading the page

This comment has been minimized.

@vodnik

vodnik Jan 17, 2019

Owner

Yes! Geolocation can be fiddly from a developer's perspective. Unfortunately, not all browsers yet deal with this in a standard way, so there are these unfortunate corner cases where nothing happens and the user may not understand why or how to fix it. The web is always a work in progress!

sort: 'relevance',
};

// loop through searchOptions object and append each key/value pair to build full search URL

This comment has been minimized.

@vodnik

vodnik Jan 17, 2019

Owner

I find comments really useful to make notes to myself and document what's going on, as you're doing here. I totally encourage this practice!

@vodnik vodnik merged commit 58bc460 into vodnik:master Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment