submitting homework 1 #1

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
2 participants
@cubofantastico
Contributor

cubofantastico commented Nov 28, 2018

No description provided.

@vodnik

vodnik approved these changes Nov 30, 2018

read up on if/else conditional statements at https://mdn.io/if...else).
*/

// // Problem with bottleCount-1 when we get to one bottle. Still need to figure out how to write 'No bottles of beer on the wall'

This comment has been minimized.

@vodnik

vodnik Nov 30, 2018

Owner

I find leaving notes about the status of code really useful, and I encourage you to keep doing this!

bottleCount--;
};

console.log(

This comment has been minimized.

@vodnik

vodnik Nov 30, 2018

Owner

Bonus points! 🍺

bottleCount--;
}; */

let bottleCount = 99;

This comment has been minimized.

@vodnik

vodnik Nov 30, 2018

Owner

I like how you iterated and got to the solution, leaving your previous work in the document. Nice job sticking with it and getting there step by step!


document.getElementById('create').addEventListener("click", function(){
newStartup();
currentStartup = newStartup();

This comment has been minimized.

@vodnik

vodnik Nov 30, 2018

Owner

Good correction here (versus the previous line).

});

document.getElementById('save').addEventListener("click", function(){
if (favStartups.indexOf(currentStartup) === -1) {

This comment has been minimized.

@vodnik

vodnik Nov 30, 2018

Owner

Your code is really well written, Daniel. I like that you included a check to make sure that the same favorite won't be added if it's already there. Great job!

@vodnik vodnik merged commit 38b27ce into vodnik:master Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment