debug randomizer.js in solution branch #18

Closed
bengitscode opened this Issue Feb 27, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@bengitscode

bengitscode commented Feb 27, 2017

No description provided.

@raq929

This comment has been minimized.

Contributor

raq929 commented Feb 27, 2017

The randomizer currently isn't very random. Also, if you give it an invalid file path, it doesn't throw an error. Boo.

raq929 pushed a commit to ga-wdi-boston/node-api-promises that referenced this issue Feb 27, 2017

racheltstevens
Separate concerns
Per ga-wdi-boston/node-api#7
Fixes randomizer script ga-wdi-boston/node-api#18
Moves process.argv issues to `bin/<file-name>`
Keeps other logic in `lib/<file-name>`
Uses string interpolation in `lib/hey-yall.js`
@gaand

This comment has been minimized.

gaand commented Feb 28, 2017

Since it's an array, npm install --global knuth-shuffle

@raq929

This comment has been minimized.

Contributor

raq929 commented Mar 1, 2017

This is also fixed in a different way in node-api-promises

jordanallain pushed a commit that referenced this issue May 1, 2017

jordanallain
Add solution code
Update for cohort lm01
- Uses `readline` instead of `readFile` for hey-yall.js
- Uses `knuth-shuffle` for randomizer.js
- Closes #18

jordanallain pushed a commit that referenced this issue May 4, 2017

jordanallain
Add solution code
Update for cohort lm01
- Uses `readline` instead of `readFile` for hey-yall.js
- Uses `knuth-shuffle` for randomizer.js
- Closes #18
@jordanallain

This comment has been minimized.

Contributor

jordanallain commented Nov 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment