Follow one .then() syntax #10

Closed
payne-chris-r opened this Issue Dec 8, 2016 · 0 comments

Comments

Projects
None yet
4 participants
@payne-chris-r
Contributor

payne-chris-r commented Dec 8, 2016

The example code uses several different .then syntaxes. Use one. Stick to it.

@gaand

This comment has been minimized.

gaand commented Dec 8, 2016

I'm not sure what this means. Is this a formatting issue?

@payne-chris-r

This comment has been minimized.

Contributor

payne-chris-r commented Dec 8, 2016

Yes. Formatting. All should look like this:

doAsyncSomething()
  .then()
  .then()
  .catch()

NOT

doAsyncSomething().then()

OR

doAsyncSomething()
.then()
.catch()
@gaand

This comment has been minimized.

gaand commented Dec 8, 2016

Agreed. @ga-wdi-boston-migrated/core without objection?

@raq929

This comment has been minimized.

Contributor

raq929 commented Dec 13, 2016

Agreed.

@raq929

This comment has been minimized.

Contributor

raq929 commented Feb 27, 2017

Per @jrhorn424 we need to make this consistent across other repos.

@jrhorn424

This comment has been minimized.

jrhorn424 commented Feb 27, 2017

(props to @raq929 for catching that we were parsing @payne-chris-r's comment differently)

As it currently reads to me, in English, to me:

Formatting for Promise chains should be either flush or indented two spaces, not all on one line.

As it currently reads to @raq929, with correct English (😉):

Formatting for Promise chains should not be all on one line nor flush, but instead indented with two spaces.

Turns out, "nor" versus "or" is a thing.

Fun party game: try to guess whether it was a traumatic English class, or a traumatic formal logic class, which forced me to learn the difference. (<-- good job, me, on parallel construction and favoring "which" over "that")

@MicFin MicFin closed this in 58d750a Feb 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment