016/master #7

Merged
merged 9 commits into from Mar 7, 2017

Conversation

Projects
None yet
2 participants
@bengitscode
Contributor

bengitscode commented Mar 3, 2017

Refresh for cohort 016

Addresses #6 #5 #4 #3

Ben Adamski added some commits Mar 3, 2017

Ben Adamski
Update from study-template
-  Refresh for cohort 016.
-  .gitignore update.
Ben Adamski
Remove signup for mlab instruction
-  Close #6
-  Developers are not expected to have an mlab account at this
point in the course. For consistency and clarity, I've chosen
to separate mlab account creation and heroku into their own
sections of steps.
-  Relied heavily upon the process @kibs98 used and recorded in
issue #5 as it was precisely how a developer with a heroku account
but NO mlab account would execute the process.
-  Fix `accessed` typo on `A full list of Heroku commands...
Ben Adamski
Add Heroku logs suggestion to troubleshooting
-  Developers should explicitly know how to access heroku logs.
-  `heroku --help` and `heroku logs` should be enough to debug
most issues encountered in previous iterations.
Ben Adamski
Remove Create Heroku account section
-  Developers all have created heroku accounts.
-  If this sequence were to change it is very easily solved by
googling how to create a heroku account.
Ben Adamski
Create mlab Addon section
-  Based heavily on #5
-  Links to section below Heroku separately.
-  End of section links back to heroku deployment to finish
process.
Ben Adamski
Reflow mlab add on instruction
-  Better follow command syntax.

@MicFin MicFin requested a review from bengitscode Mar 6, 2017

@bernardlee bernardlee requested a review from bengitscode Mar 6, 2017

@raq929 raq929 requested a review from bengitscode Mar 6, 2017

@bernardlee bernardlee removed the request for review from MicFin Mar 6, 2017

@raq929 raq929 removed the request for review from MicFin Mar 6, 2017

@MicFin MicFin self-assigned this Mar 6, 2017

Ben Adamski added some commits Mar 6, 2017

Ben Adamski
Add Heroku Account to prequisites
-  Developers should have a heroku account by now, having created
one in the full-stack-project, but it makes sense to list this as
a prerequisite since the guide assumes you have a heroku account.
Ben Adamski
Provide start of guide with further clarification
-  Make very clear where developers are starting from to deploy
their projects. Per @MicFin suggestion.
Ben Adamski
Enhance Heroku prerequisite
-  Adds toolbelt CLI and links back to rails-heroku-deployment
guide's original instructions for signing up to heroku, and using
brew to install the toolbelt.

@MicFin MicFin merged commit aa8cd51 into master Mar 7, 2017

@MicFin MicFin deleted the 016/master branch Mar 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment