022/master #41

Merged
merged 10 commits into from Feb 14, 2018

Conversation

Projects
None yet
2 participants
@tvlangley
Contributor

tvlangley commented Jan 30, 2018

Template update

Chris and others added some commits Jan 18, 2018

Update Ember version
Update using commit from planning-genie
wdi-bos-faculty/planning-genie-client@df3a69e
Addresses #37
Moves ember-cli-shims
With 2.16 ember moved shims to package.json.
Update using commit from planning-genie
wdi-bos-faculty/planning-genie-client@39347fe
Addresses #37
Updates import syntax for v 2.16
Previous versions of ember imported it via just importing the Ember
object:
`import Ember from 'ember'`

The favored syntax is now:
`import { PieceOfEmber }` from '@ember/PieceOfEmberThing'

This was done using `ember-modules-codemod` command
Close #37
Fixes typo in phantomjs installation instruction
Changes `npm install --global phantomjs-prebuil` to
`npm install --global phantomjs-prebuilt`
close #19
Add application serializer test
Add test from generating an application serializer
close #23
Adds to list of files that need app name
Adds `app/adapters/application.js` to list of files that need app name
close #26
Remove all references to `bower`
- Move dependencies from bower.json to package.json
- Remove references to bower
Close #34
Update package.json
Update dependencies to align with Ember's new module import syntax
Addresses #37
Remove pod references
Remove pod references from README
close #39

@tvlangley tvlangley requested a review from payne-chris-r Jan 30, 2018

@payne-chris-r

We definitely dont need light-table. I'm pretty sure we don't want concurrency either, but I might be wrong.

Show outdated Hide outdated package.json Outdated
Show outdated Hide outdated package.json Outdated
Remove dependencies
Remove dependencies not needed for this template
'ember-bootstrap': {
'bootstrapVersion': 3,
'importBootstrapFont': true,
'importBootstrapCSS': false

This comment has been minimized.

@payne-chris-r

payne-chris-r Feb 14, 2018

Contributor

are we sure we don't want BootstrapCSS?

@payne-chris-r payne-chris-r merged commit 490e1e1 into master Feb 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment