Do we need `ember-export-application-global` package? #54

Closed
caleb-pearce opened this Issue May 15, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@caleb-pearce
Contributor

caleb-pearce commented May 15, 2018

This package isn't bundled with Ember by default, and as far as I can tell all it does is expose the Ember app object as window.GaWdiBostonEmberTemplate, which we don't use anywhere. Can we get rid of it?

@caleb-pearce

This comment has been minimized.

Contributor

caleb-pearce commented May 15, 2018

Same for ember-cli-release which seems to be a tool for versioning, but we don't use version numbers on our repos.

@jordanallain

This comment has been minimized.

Contributor

jordanallain commented May 15, 2018

seems likely. did you get rid of it and see if it had any effect?

@MicFin

This comment has been minimized.

Contributor

MicFin commented May 15, 2018

Those both look like packages we could do without. I'd imagine at one point the plan was to use window.GaWdiBostonEmberTemplate for pedagogical reasons but we have not been.

@caleb-pearce

This comment has been minimized.

Contributor

caleb-pearce commented May 15, 2018

@jordanallain All the auth template functionality works without these two, I think. ember-cli-relase at least is purely a CLI thing so it shouldn't break any apps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment