Do we need a serializer/serializer test for the template? #45

Closed
jordanallain opened this Issue Feb 22, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@jordanallain
Contributor

jordanallain commented Feb 22, 2018

The ember-template has a serializer and test for it that will produce errors when running the ember test for a newly cloned ember-template.

If you generate a model for the application route, all the tests will pass because the serializer then has something to reference.

To solve this problem we can either add a generated model for application to the template, or get rid of the serializer for it which I think makes sense since we don't actually have any data in the template. I would vote for generating the serializer when you need it but maybe someone else has another opinion?

@MicFin

This comment has been minimized.

@tvlangley

This comment has been minimized.

Contributor

tvlangley commented Feb 22, 2018

That is indeed the test that fails and the file it's testing. The fix was stated above:

If you generate a model for the application route, all the tests will pass because the serializer then has something to reference.

@MicFin

This comment has been minimized.

Contributor

MicFin commented Feb 22, 2018

I think I like this one

get rid of the serializer for it which I think makes sense since we don't actually have any data in the template

Because we aren't using an application wide serializer nor an application wide model for it to serialize for us.

@MicFin MicFin closed this in fdd1645 Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment