016/master #20

Merged
merged 10 commits into from Mar 20, 2017

Conversation

Projects
None yet
3 participants
@bengitscode
Contributor

bengitscode commented Mar 20, 2017

No description provided.

Ben Adamski added some commits Mar 13, 2017

Ben Adamski
Update from ember-template
-  Refresh for cohort 016.
-  Removes pod structure.
Ben Adamski
Address Jshint linter errors
-  In tests/ and app/router.js
-  Ember test still fails on a jshint error.
Ben Adamski
Correct typo in Readme
-  "important pieces" not piece.
Ben Adamski
Add annotations to getter/setter example
-  Address and close #18.
-  Enhance annotations to show return value, as other example.
Ben Adamski
Move and rename files from template depodification
-  moved and renamed following:
-  app/controllers/.gitkeep -> app/models/.gitkeepy
-  app/application/serializer.js -> app/serializers/application.js
-  tests/unit/application/adapter-test.js ->
tests/unit/adapters/application-test.js
Ben Adamski
Change Bob example to Tina
-  Tina doesn't have children.
-  Example makes more sense this way.
Ben Adamski
Correct Lab instructions
-  Address and close #17.
-  Correct `ember serve command`.
-  Correct port number.

@MicFin MicFin requested a review from bengitscode Mar 20, 2017

Ben Adamski added some commits Mar 20, 2017

Ben Adamski
Enhance language in README
-  Remove use of obviously.
Ben Adamski
Repair code block
-  Add closing codeblock back tics on line 71.

@bernardlee bernardlee merged commit 9b572b2 into master Mar 20, 2017

@jrhorn424 jrhorn424 removed the in progress label Mar 20, 2017

@bernardlee bernardlee deleted the 016/master branch Mar 20, 2017

@MicFin MicFin removed their request for review Mar 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment