016/solution #101

Closed
wants to merge 6 commits into
base: solution
from

Conversation

Projects
None yet
4 participants
@bengitscode

bengitscode commented Mar 21, 2017

@raq929 this is not complete. I'm still trying to debug the solution (did it ever?)

I want to get this solution fixed but it's more important that working master is updated.

Will update a comment here if there's an update.

Ben Adamski and others added some commits Mar 20, 2017

Ben Adamski
Update from diagnostic-template
-  Refresh for cohort 016.
Ben Adamski
Update from ember-template
-  Refresh for cohort 016.
-  Depodify structure.
Ben Adamski
Appease Jshint
-  Grunt nag runs clean.
-  Ember test still shows 2 Fails:
 -  PhantomJS blows up listing files that should
pass JShint and AFAIK they do.
Ben Adamski
Make explicit that diagnostic.js is diagnostic
-  Address and close #99
-  Make explicitly clear that all work for diagnostic will be
written in `public/diagnostic.js`
-  Explicitly instruct not to touch anything inside ember app.
Ben Adamski
Update from ember-template
-  Refresh for cohort 016.
-  Depodify structure.
Update solution branch
Refresh for cohort 015

@raq929 raq929 self-assigned this Mar 21, 2017

@jrhorn424

This comment has been minimized.

jrhorn424 commented Mar 22, 2017

Why wasn't this "merged"? That is, why wasn't solution updated?

@bengitscode

This comment has been minimized.

bengitscode commented Mar 22, 2017

@jrhorn424 I just spoke to Rachel about this. Her concern was that because of the commit, that the solution and master's diff would contain more than just the solution. The diff in question was removed in a later commit.

The diff of 016/solution and 016/master is only the solution in public/diagnostic.js not that jshint fix in app/router. With that cleared up, this is good to merge unless @raq929 disagrees.

@jrhorn424 jrhorn424 closed this Apr 14, 2017

@jrhorn424 jrhorn424 removed the in progress label Apr 14, 2017

@jrhorn424 jrhorn424 reopened this Apr 14, 2017

@jordanallain jordanallain deleted the 016/solution branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment