016/master #100

Merged
merged 4 commits into from Mar 21, 2017

Conversation

Projects
None yet
3 participants
@bengitscode

bengitscode commented Mar 21, 2017

Refresh for cohort 016

-still debugging solution branch.

Ben Adamski added some commits Mar 20, 2017

Ben Adamski
Update from diagnostic-template
-  Refresh for cohort 016.
Ben Adamski
Update from ember-template
-  Refresh for cohort 016.
-  Depodify structure.
Ben Adamski
Appease Jshint
-  Grunt nag runs clean.
-  Ember test still shows 2 Fails:
 -  PhantomJS blows up listing files that should
pass JShint and AFAIK they do.
Ben Adamski
Make explicit that diagnostic.js is diagnostic
-  Address and close #99
-  Make explicitly clear that all work for diagnostic will be
written in `public/diagnostic.js`
-  Explicitly instruct not to touch anything inside ember app.

@raq929 raq929 requested a review from bengitscode Mar 21, 2017

@raq929

This comment has been minimized.

Contributor

raq929 commented Mar 21, 2017

What do you mean by phantomjs blows up?
Travis is saying that tests are failing, which is a separate issue.

raq929 added a commit that referenced this pull request Mar 21, 2017

@raq929 raq929 merged commit e6a15c6 into master Mar 21, 2017

@raq929 raq929 deleted the 016/master branch Mar 21, 2017

@jrhorn424 jrhorn424 removed the in progress label Mar 21, 2017

@bengitscode

This comment has been minimized.

bengitscode commented Mar 22, 2017

@raq929 RE:phantomjs that was my misunderstanding; phantomjs (i think) was blowing up because I missing a test file, and I think the tests are failing because that file is a test file. This repo doesn't have tests for the diagnostic (just the defaults generated by the ember app) so it won't effect the delivery in this iteration. I've opened an issue with what I believe to be the missing test files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment