016/master #13

Merged
merged 8 commits into from Mar 23, 2017

Conversation

Projects
None yet
3 participants
@bengitscode
Contributor

bengitscode commented Mar 22, 2017

There are no updates from study-template as there were no changes. This should be updated from guide-template which does not yet exist (I'm making one per Antony's instruction).

Ben Adamski added some commits Mar 22, 2017

Ben Adamski
Explicitly note that apiHost will need to be added
-  Explicitly notes that if they do not have apiHost from the
example, that they will need to add it manually.
Ben Adamski
Change application/adapter to adapter/application
-  This was moved in the great ember depodification of 016.
-  Address #10
Ben Adamski
Change ajax/services to services/ember-ajax
-  Another change from the depodification. Services are now stored
in the services directory.
Ben Adamski
Make dist/ removal in gitignore more clear
-  Clarify the distinction of why we are adding dist and why it
shows up in git status after commenting out in gitignore.
-  This was a clarity issue in 015
-  Address #9
Ben Adamski
Update let to const in config/environment steps
-  This changes let to const in the bold "Yes, use var" section.
-  It appears to deploy successfully with that ENV declared with
const, var or let.
-  I decided to address this with the option that required the smallest diff,
to avoid introducing changes that could break the deployment process.

@jrhorn424 jrhorn424 requested a review from bengitscode Mar 22, 2017

Ben Adamski added some commits Mar 23, 2017

Ben Adamski
Remove markdown from within details tag
-  The browser will not be able to properly parse the markdown inside
HTML.
-  Also removes extraneous <options> tag.
-  Addresses requested changes in review of #13
Ben Adamski
Enhance clarity of var,let,const warning
-  Addresses requested changes in review of #13
-  Explictly note not to use let or const, only var.
Ben Adamski
Move why git add dist/ section below steps
-  The final steps of deployment are important and currently read
as a succinct list of steps. I'm moving this below so that the
explanation is still included in the guide, without sacrificing
any readability of the deployment steps.
-  This isn't perfect, but it's much better.
@bengitscode

This comment has been minimized.

Contributor

bengitscode commented Mar 23, 2017

Comments addressed @jrhorn424

raq929 added a commit that referenced this pull request Mar 23, 2017

@raq929 raq929 merged commit 68387c3 into master Mar 23, 2017

@raq929 raq929 deleted the 016/master branch Mar 23, 2017

@jrhorn424 jrhorn424 removed the in progress label Mar 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment