Remove `var` and prefer `let` in `config/environment.js` #12

Closed
bengitscode opened this Issue Mar 22, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@bengitscode
Contributor

bengitscode commented Mar 22, 2017

see 315cf02

We're not yet sure if something in the browsers or Broccoli has changed that seems to allow us to deploy successfully using let.

I went with keeping var to introduce less significant change and stick with what has worked up to this point. It may be perfectly okay to use const or let but we should confirm that officially before changing anything. The change made in the above commit allows us to keep ember-template the way it is while we confirm this or not as it pertains to deployment specifically.

@gaand

This comment has been minimized.

gaand commented Mar 26, 2017

😠 🤖

@danman01

This comment has been minimized.

danman01 commented Dec 15, 2017

As of ember-cli: 2.17.0, let is now in environment.js by default

@danman01 danman01 changed the title from Need to confirm use of var, let, const in `config/environment.js` to Remove `var` and prefer `let` in `config/environment.js` Dec 15, 2017

@bengitscode

This comment has been minimized.

Contributor

bengitscode commented Dec 15, 2017

Awesome! We should test it with the grunt deploy script, but it sounds like that's not going to be an issue 🙌

@jordanallain

This comment has been minimized.

jordanallain commented Apr 11, 2018

sounds like according to danny, it generates the code with let so that should be safe to use. maybe we should test deploy though.

Jcornmanhomonoff added a commit that referenced this issue Apr 11, 2018

Remove note about `let` & `const`
- Okay to use `const`
- Close #12

@MicFin MicFin closed this in 62f248e Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment