Would it be appropriate to ignore all .csv files? Would it be appropriate to block both credentials.csv and accessKeys.csv? #36

Closed
bengitscode opened this Issue Jun 16, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@bengitscode
Contributor

bengitscode commented Jun 16, 2017

This was a question Jeff raised, on github in PR 016 https://github.com/ga-wdi-boston/aws-s3-setup-guide/pull/20 (never merged)

I closed the PR as it was mine, and I'm basing the most recent update for 018 delivery.

I will be updating for the 018 iteration without making this change, but we should still consider it. I doubt AWS will suddenly change the name of the credentials.csv anytime soon (or never) but it would cover all bases in case that happened.

@Jcornmanhomonoff

This comment has been minimized.

Contributor

Jcornmanhomonoff commented Jul 10, 2018

The only csv file that we download/use is the accessKey.csv so I don't see any reason why we need to ignore all csv files.

@caleb-pearce

This comment has been minimized.

Contributor

caleb-pearce commented Jul 10, 2018

Adding credentials.csv and accessKey.csv to the global .gitingore would probably be a good plan.

Jcornmanhomonoff added a commit that referenced this issue Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment